-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
187887752 date format improvements, attribute refinements #23
Conversation
- setting up constants for iteration/testing - improve day calculations to avoid cross-midnight issues
… allow for meaningful graphs of sunrise and sunset times
- make all attributes show and disable hide/show for now (bug to fix) - make attributes for clock times categorical - set format to hh:mm a
- if we spring forward, we lose an hour - it will come out of day length if transition happens after sunrise, in UTC - so on transition days like this we can adjust to remove outlier - but this is commented out for now
asClockTimeStringAMPM: "h:mm a", // 2:45 PM | ||
} | ||
|
||
export const kDateFormats = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we end up using formulas for the date display column we will not need these, these are mostly here for making iteration easier.
…r other attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM -- just a couple of minor comments/suggestions.
This makes some adjustments to address date formatting issues evident in work originating in PT-187887752. It also contains fixes that address PT-187887752 and PT-188074070 and PT-188092756 and PT-188045605
Changes: